Fix go_repository configuration #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* go_repository now supports a build_config attribute. By default, this points to "@//:WORKSPACE", but it may reference another file that changes less frequently or None. This is used to set the -repo_config option when invoking Gazelle. * A global default may be set via "go_repository_default_config" in gazelle_dependencies. * go_repository now reads files with "cat" instead of ctx.read. Fixes bazel-contrib#555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimal module compatibility, and
go_bazel_test.//internal:repository_rules_testto//internal:go_repository_test.The old test was broken by incompatible changes in new versions of Bazel.
The new test uses a new integration testing framework. We should be able
to improve
go_repositorytest coverage in the future.//internal/language/test_filegroup, an extension that generatesall_filesfilegrouptargets in each package. This is needed forgo_bazel_test, since it explicitly depends files in repositories under test.